Revised CalCat API

This is based on our discussion last week, but it's still a WIP. In particular, I haven't implemented actually loading the constants yet.

I've tweaked the design slightly: rather than having CalibrationData subclasses for each detector type, you use CalibrationData.from_conditions() with a detector specific object like AGIPDConditions. Jump to the tests to see what this looks like.

Questions:

• How to deal with missing modules?
  • A module may be missing for one type of constant but not for another
  • How do we even tell if modules are missing - should we query the PDUs so we know how many modules to expect?
• How to deal with missing calibration types (e.g. SlopesPC)
  • Especially if one group (e.g. illuminated) not found - this currently raises an error, even if we have other constants we could return
• Naming:
  • 'Calibrations' vs 'calibration' types vs 'constant types' (e.g. Offset, SlopesPC
  • 'Modules' vs 'aggregators'
• How many of SingleConstantVersion fields do we actually want?
• Should .select_modules() and .select_calibrations() take *args or a list?

cc @schmidtp @ahmedk @hammerd

tests/test_calcat_interface2.py

@@ -4,6 +4,7 @@ from cal_tools.calcat_interface2 import (
     CalibrationData,
     AGIPDConditions,
     DSSCConditions,
+    LPDConditions,
     SingleConstantVersion,
 )
 
@@ -67,11 +68,26 @@ def test_DSSC_modules_missing():
     )
     # DSSC was used with only 3 quadrants at this point
     modnos = list(range(4)) + list(range(8, 16))
-    assert dssc_cd.aggregator_names == ['DSSC{m:02}' for m in modnos]
+    assert dssc_cd.aggregator_names == [f"DSSC{m:02}" for m in modnos]
     assert dssc_cd.module_nums == modnos
-    assert dssc_cd.qm_names == [
-        f"Q{(m // 4) + 1}M{(m % 4) + 1}" for m in modnos
-    ]
+    assert dssc_cd.qm_names == [f"Q{(m // 4) + 1}M{(m % 4) + 1}" for m in modnos]
+
+
+@pytest.mark.requires_gpfs
+def test_LPD_constant_missing():
+    lpd_cd = CalibrationData.from_condition(
+        LPDConditions(memory_cells=200, sensor_bias_voltage=250),
+        "FXE_DET_LPD1M-1",
+        event_at="2022-05-22T02:00:00",
+    )
+    # Constants are missing for 1 module (LPD05), but it was still included in
+    # the PDUs for the detector, so it should still appear in the lists.
+    assert lpd_cd.aggregator_names == [f"LPD{m:02}" for m in range(16)]
+    assert lpd_cd.module_nums == list(range(16))
+    assert lpd_cd.qm_names == [f"Q{(m // 4) + 1}M{(m % 4) + 1}" for m in range(16)]
+
+    assert len(lpd_cd["Offset"].module_nums) == 16
+    assert len(lpd_cd["Offset"].constants) == 15
 
 
 @pytest.mark.xfail