Skip to content
Snippets Groups Projects

[Jungfrau][Correct] Fix not returning after finding a dark fixed gain constants

Merged Karim Ahmed requested to merge fix/return_force_fixed_constants into master

Description

A bug was found during MID BUD. The data being corrected was in dynamic gain and as a result, a fixed gain constant is forced to be retrieved and used. The correction failed even though there were fixed dark constants found. The reason was a bug of not returning the retrieved CCVs and instead going for retrieved dynamic constants.

How Has This Been Tested?

THIS IS HOTFIXED IN PRODUCTION: COMPLETED_MID_EXP_JF500K1_correct.pdf

  • Is there another way to test this part without depending on the reference runs we have?

Relevant Documents (optional)

FAILED_MID_EXP_JF500K1_correct.pdf

Types of changes

Checklist:

Reviewers

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed marked this merge request as ready

    marked this merge request as ready

  • Karim Ahmed changed title from Fix not returning after finding a dark fixed gain constants to [Jungfrau][Dark] Fix not returning after finding a dark fixed gain constants

    changed title from Fix not returning after finding a dark fixed gain constants to [Jungfrau][Dark] Fix not returning after finding a dark fixed gain constants

  • Karim Ahmed changed title from [Jungfrau][Dark] Fix not returning after finding a dark fixed gain constants to [Jungfrau][Correct] Fix not returning after finding a dark fixed gain constants

    changed title from [Jungfrau][Dark] Fix not returning after finding a dark fixed gain constants to [Jungfrau][Correct] Fix not returning after finding a dark fixed gain constants

  • Thanks, LGTM.

  • Karim Ahmed changed milestone to %3.12.2

    changed milestone to %3.12.2

  • merged

  • Karim Ahmed mentioned in commit b2122173

    mentioned in commit b2122173

Please register or sign in to reply
Loading