Skip to content

[GH2][Correct] Fix the warning when module not reversed and reverse raw data before correction

Karim Ahmed requested to merge fix/reverser_before_correction into master

Description

This is a fix for the implementation for !952 (merged)

After discussing with @mramilli and @schmidtp, we agreed that the dark constants are(and should) always be injected in for the reversed second module.

There will be efforts to motivate not configuring the reverseSlaveReadOutMode. But in the rare case, if this happens, the flipping should be done before applying the corrections.

Also a warning is raised that second module is not reversed.

How Has This Been Tested?

  • TBD

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@hammerd @schmidtp @mramilli

Edited by Karim Ahmed

Merge request reports