Skip to content

[AGIPD][CORRECT][DARK] Break wrong assumption for availability for 1st module

Karim Ahmed requested to merge fix/get_bias_voltage_correct_module into master

Description

This is to address this ticket: https://redmine.xfel.eu/issues/170549

  1. To process dark data with correct conditions, the YAML file needed updating, specifically adding "bias-voltage: 300" to avoid determining it from AGIPD slow data. This adjustment was necessary because the value of HV required for setting operational conditions was previously derived from channel 0, which cannot now be powered. After modifying the YAML file, darks are processed without any issues, and the constants are injected into the calibration DB, retrievable by the online pipeline.

This is a comment in the ticket from Jola. It shows a bug in the notebooks on how we assume the availability of 1st module.

I have exposed module input argument to update in get_bias_voltage and added some comments to discuss in this MR on optional improvements

How Has This Been Tested?

CI tests.

The tests failed because some modules had 299 and others had 300 bias voltage for MID and SPB dark runs. Also for HED some modules had 199 and some others had 200 bias voltages.

Screenshot_from_2024-03-18_12-28-40

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@kluyvert @hammerd

Edited by Karim Ahmed

Merge request reports