Skip to content
Snippets Groups Projects

[JUNGFRAU][DARK] New notebook for summarizing processed darks

Merged Karim Ahmed requested to merge fix/jungfrau_dark_summary_across_modules into master

The report for Jungfrau dark processing is too long. This introduces the summary report in a similar sense used for AGIPD, LPD, and DSSC.

Related issue: https://git.xfel.eu/calibration/planning/-/issues/127

Description

  1. Update individual dark notebooks.
    a. Add detailed_report (Open for different names) to plot the multiple individual module/cells/gain plots. Which can expand a report to a 100+ pages b. Retrieve previous constants and store them in YAML file per module. (The same as already done for AGIPD, LPD, and AGIPD)

  2. Introduce Summary notebook:
    a. Read current constants stored locally and load previous constants from YAML files.
    b. Plot a mean across cells for Offset, Noise, and BadPixelsDark constants.
    c. Additionally, plot the difference between Current and Previous constants in ADU and in percentage.
    d. Show extra plots for mean for constants across pixels per memory cells for burst mode only.

NOTE: this MR is based on another MR at https://github.com/European-XFEL/EXtra-geom/pull/177

How Has This Been Tested?

  • Test with reference runs.

Relevant Documents (optional)

An example for the current report for SPB_IRDA_JF4M for single cell mode

SPB_IRDA_JF4M_dark_old.pdf

New Reports:

SPB_IRDA_JF4M_dark.pdf

HED_IA1_JF500K1_dark.pdf

FXE_XAD_JF500K_dark.pdf

FXE_XAD_JF1M_dark_single.pdf

An example for the burst mode for FXE_XAD_JF1M

FXE_XAD_JF1M_dark_burst.pdf

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@mramilli @schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed mentioned in merge request !735 (merged)

    mentioned in merge request !735 (merged)

  • Philipp Schmidt approved this merge request

    approved this merge request

  • Karim Ahmed changed milestone to %3.7.2

    changed milestone to %3.7.2

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed added 37 commits

    added 37 commits

    • 30614e0b...9d059b35 - 32 commits from branch master
    • 67f59a35 - New Jungfau notebook for summarizing processed darks
    • 19856cf3 - Show data over memory cells for burst mode
    • 5855ce19 - different figsize based on number of modules
    • b3c4ee68 - put back detailed imaged as requested and add detailed report flag
    • 3800a811 - update extra-geom, cfelpyutils, update plot, and dont remove module YAML files

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading