Description
This MR offers an improved implementation of a feature that used to be available in calPy, but is no longer available.
The detector sometimes send data incorrectly, when configuration was not correctly applied.
This is difficult to see as the detector behaves otherwise correctly.
This can be monitored by checking that the cellId vs. pulseId are incrementing together, following the veto pattern.
The cellId and pulseId are available as output of the calibration pipeline as ndarrays, but it is be preferable to have VectorUInt32, as then these can be used with the XYGraph widget in the GUI.
Additionally, this device implements a simulation of the detector's algorithm, which can be used to validate the output rather than keeping an eye on it.
How Has This Been Tested?
This is being tested at the DETLAB.
Relevant Documents (optional)
There's a simplistic built-in scene:
Types of changes
-
Bug fix (non-breaking change which fixes an issue) -
New feature (non-breaking change which adds functionality) -
Breaking change (fix or feature that would cause existing functionality to not work as expected) -
Docs (changes to the documentation) -
Style (formatting changes only, no code changes) -
Refactor (refactoring code with no functionality changes) -
Test (additional or refactored tests) -
Chore (non-code changes, e.g. comments, readme, grammar, etc...)
Checklist:
-
My code follows the code style of this project. -
My change requires a change to the documentation. -
I have updated the documentation accordingly. -
I added tests where appropriate.
Reviewers
-
I need a review from: -
I have asked Controls for review