Skip to content

Add DaqPolicy properties filtering device

Cyril Danilevski requested to merge initial_implementation into main

Description

This device aims to resolve an issue with the DSSC detector control device which has too many properties for the DAQ to record.
The concept is detailed more thoroughly in README.md, but effectively filters properties based on their DaqPolicy and injects them in this middlelayer device instance, which can be added to a run configuration group instead of the original, larger, device.

While reviewing, I'd particularly appreciate feedback on the update monitoring of the source device, as well as the proxy management as I'm not up to date with the latest best-practices.

How Has This Been Tested?

This was tested in the DETLAB topic.
It's running on xctrl@detlab-rr-sys-con-ladet, and can be found in the DETLAB -> DETLAB_FENICE -> DITM_TEST project, where properties of DETLAB_FENICE/FPGA/PPT_Q1 are being filtered and updated when changed.
Some of these properties are within nodes.

I have yet to do an end-to-end test with the DAQ.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Reviewers

@giovanet @agarciat

Merge request reports

Legal Notice | Contacts