FFT sample Z mnemonics
The sample Z mnemonics were introduced in 98365cd4. In principle, hyphens should be avoided in mnemonics names, otherwise calling the variables as attributes of a dataset doesn't work:
With dataset ds
and variable var_1
, one can call var_1
using ds.var_1
, but this wouldn't work if we named the variable var-1
(then one can only call it via ds["var-1"]
).
Also, since the encoder value is read by the motor, I don't see the need to have two mnemonics. If encoder and motor do not agree, it is a sign of a deeper problem that needs to be investigated, and probably the mnemonics of the ToolBox will not be enough for such investigation.
I propose the following changes:
- Remove the current "SAM-Z" (encoder value)
- Rename "SAM-Z-MOT" to "FFT_SAM_Z" (to differentiate with other coming up chambers)
If you want to keep the encoder value, I would like to rename the mnemonic from "SAM-Z" to "FFT_SAM_Z_ENC".
Since this mnemonic was introduced recently, only a few notebooks should be affected.