Streamline digitizer functions
1 unresolved thread
1 unresolved thread
@lleguy reported an error with this line:
run, ds = tb.load(8196, 181, fields=["XRD_MCP_SMALLraw"])
which showed that several updates of the digitizer functions were necessary.
- Remove hard-coding of bunch pattern in some functions
- Get the digitizer type based on
classId
. This solves the issue above, which occurred because of a wrong assignment of digitizer type based on the name. - Update mnemonics to allow digitizer peak extraction
- Simplify
get_digitizer_peaks
by only allowing the processing of one mnemonic at a time. - Simplify arguments of
get_peaks()
function, disable loading of data and of bunch pattern table: these should be done prior to this function.
Edited by Laurent Mercadier
Merge request reports
Activity
Filter activity
assigned to @mercadil
Is there something from
extra
that can be used? For example: https://extra.readthedocs.io/en/latest/components/adq-digitizers/This is for ADQ digitizers only and not Fast ADC, which we use the most. It could be interesting to integrate this, along with bunch pattern, xgm...but would require rewriting almost everything. For now I don't see the benefit, it does not seem to have more or better features than what the ToolBox has.
Sounds good to me.
FYI @carinanc
mentioned in commit 822de261
Please register or sign in to reply