Skip to content
Snippets Groups Projects
Commit 30431a67 authored by Philipp Schmidt's avatar Philipp Schmidt
Browse files

Merge branch 'fix/less-parallel-instantation' into 'master'

Fix matcher devices stuck in CHANGING state after instantation

See merge request !110
parents eed5d5f8 c46a6190
No related branches found
No related tags found
1 merge request!110Fix matcher devices stuck in CHANGING state after instantation
......@@ -1354,6 +1354,14 @@ class CalibrationManager(DeviceClientBase, Device):
config
))
# Perform instantation on correction devices first.
if not all(await gather(*awaitables)):
self._set_status('One or more correction devices failed to '
'instantiate')
return
awaitables.clear()
# Instantiate group matchers with optional bridge enabled.
for row in self.moduleGroups.value:
group, server, with_bridge, bridge_port, bridge_pattern = row
......@@ -1402,9 +1410,10 @@ class CalibrationManager(DeviceClientBase, Device):
config
))
# Perform instantation.
# Perform instantation on matcher-like devices second.
if not all(await gather(*awaitables)):
self._set_status('One or more devices failed to instantiate')
self._set_status('One or more matcher devices failed to '
'instantiate')
return
# Force managed DAQ settings.
......@@ -1436,7 +1445,7 @@ class CalibrationManager(DeviceClientBase, Device):
if assemblers:
for remote_key, local_key, _ in self._managed_assembler_keys:
await self._set_on_assembler(
await self._set_on_assemblers(
remote_key, get_property(self, f'managedKeys.{local_key}'))
if corrections:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment