Snapshot: field test deployed version as of end of run 202201
Apologies for the massive diff. Would suggest reviewing subset of devices / files. BaseCorrection
and AgipdCorrection
were reviewed quite a bit in https://git.xfel.eu/karaboDevices/calng/-/merge_requests/3 - unfortunately, the diff doesn't really do much to show what happened since then.
Main points:
- switched to assuming Karabo >= 2.14.1 (mostly to get and catch
RuntimeError
for empty hashes) - support for more detectors
- Was in last time: AGIPD, DSSC
- New: LPD, JUNGFRAU (non-XTDF), GOTTHARD-II (non-XTDF, strip)
- switch to
DetectorAssembler
and geometry devices for preview- would be nice to have review of
base_geometry.py
; provides base class for geometry devices and the subclasses undergeometries/
are fairly trivial
- would be nice to have review of
- add stacking feature to
ShmemTrainMatcher
- merged dynamic manager branch some time ago
What is not so important to review (for now):
-
scenes.py
is just a lot of scene generation - certain parts of correction devices will be refactored in next MR (which will add better warning lamps and condition checkers):
- anything to do with loading and flushing constant buffers (e.g.
flush_constants
,flush_buffers
,_load_constant_to_runner
) - anything to do with mapping from correction step enums to device schema (e.g.
add_correction_step_schema
and_correction_field_names
)
- anything to do with loading and flushing constant buffers (e.g.
The state of things as of this snapshot corresponds to recent deployed version at SPB and FXE used with OnDA. Automatic testing not yet in place; typically spawning test pipelines in PLAYGROUND
project hammerd-cal-dev
.
Edited by Philipp Schmidt