Fix correction addon interface

This adds device and prefix parameters to correction addons constructor. It allows to avoid the additional injection of this parameters in base_correction outside the interface and get rig of additional initialization call after it.

@hammerd

Style-wise this seems prudent to not set properties from the outside. What additional initialization call you mean though?

In some cases (e.g. autocorrelation addon) you need to know these additional parameters (device and prefix) on initialization. In the variant before, we need another initialization call, which is triggered after these fields set. But if we put these parameters as arguments of __init__ we actually can do everything in __init__ and don't need additional initialization code.

Ah, external addons, got it. Thanks.

LGTM. I don't have any good ways around the addons knowing about their host device and schema path - and setting them after __init__ was a very ugly hack.

Thanks, @hammerd. Please merge it whenever you think it is fine. I don't have permissions to that anyway.

According to the settings, any member that has access to the repository can merge MRs, are you sure?

Yes, now I can. Uhh, I'm confused. Sorry.

I may have played with the settings some weeks ago to adjust to the repositories being public since a while.

Ugh, it was changed since yesterday.

No, it is another branch

It seems that I cannot merge to the master

Ah, I think I found it now. The wording was misleading:

This only refers to creating MRs - the setting to merge is found under "protected branches". It should work now.

yes, it works now

merged

mentioned in commit d40d8e70