Fix getting hostname for error messages about device servers config

Error messages were including the wrong hostname, spotted while investigating this issue with a manager device refusing to start.

Ah, very good, I remember seeing this some time ago when misconfiguring things. Will close !20 (closed) (bigger changes happened to the manager back then, so didn't get around to finishing it up). My diff was a bit longer as I didn't parse the hostname from the host, so yours is better.

Do you have an opinion on the other thing I had changed in that MR: erroring out only if servers are missing rather than when expected set of servers != set of servers up (I mean, it's silly to have unnecessary servers, but that doesn't fit the error which is reported in that case).

Do you have an opinion on the other thing I had changed in that MR: erroring out only if servers are missing rather than when expected set of servers != set of servers up (I mean, it's silly to have unnecessary servers, but that doesn't fit the error which is reported in that case).

I think that idea makes sense, but I don't know this machinery very well. It might be helpful to do the set difference and include in the error message which servers are missing, rather than just 'one or more'.

Definitely. This MR LGTM, would be nice to have for next deployment. So would merge and maybe in the future consider extra warnings from missing or redundant device servers.

mentioned in merge request !20 (closed)

merged

mentioned in commit 5d6feb46