Skip to content

[Gotthard2][Dark] Calculate noise bpixs in multiple iterations

Karim Ahmed requested to merge feat/iterate_to_calculate_noise_bpix into master

Description

@mramilli mentioned that reiterating on calculating NOISE_OUT_OF_THRESHOLD badpixel type for gotthard2 showed a difference in the number of badpixels identified.

In the below figure are his test results. Each plot is the difference in bpix numbers for each gain for one of the production constants.

image

Below are my test results showing that sometimes you can get a different number of badpixels with more iterations than 2.

This MR exposes an iteration parameter to control it if needed (default 5).

Now GH2 darks will iterate to calculate the more accurate number of badpixels. each iteration costs =< 1ms, so no obvious performance drawback on dark processing.

How Has This Been Tested?

Relevant Documents (optional)

image

Types of changes

Checklist:

Reviewers

@mramilli @schmidtp @kluyvert

Merge request reports