Skip to content
Snippets Groups Projects

[Jungfrau][Correct] Account for missing modules by depending on `xarray`.

Open Karim Ahmed requested to merge fix/account_for_missing_jf_module into master

Description

This shows a problem that can be faced when not all expected modules' data are available http://max-exfl-cal001.desy.de:8008//gpfs/exfel/exp/XMPL/202150/p700002/usr/Reports/r0164/FXE_XAD_JF1M_correct_700002_r0164_240521_132426_322759.pdf

For example for JF1M in case JNGFR01 is missing, an error is raised by extra-geom for attempting to plot data with unexpected data shape.

This MR introduces keep_data_dims function which does something similar to the keep_dims boolean when set for extra-data reader. unfortunately, such functionality is not available for components. So I added this solution in cal_tools.

How Has This Been Tested?

  • Running Automated tests

Relevant Documents (optional)

jf1m_xmpl.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I added tests where appropriate.

Reviewers

@kluyvert @schmidtp

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading