Skip to content

[AGIPD][CORRECT][CS] Fix badpixelsCS before we have multiple CCVss to have same BadPixels shapes.

Karim Ahmed requested to merge fix/badpixelscs_shape into master

Description

While checking different shapes for different calibration constants, I realized using the same shape as BadpixelsPC. It's shape is not sane compared to other Badpixels constants for AGIPD and it needs reshaping before being used.

This MR when deployed needs to be accompanied with replacing the BadPixelsCS CCVs in CALCAT which is only one version so far.

BadPixels shape:

  • BadPixelsDark (128, 512, 352, 3)
  • BadPixelsFF (128, 512, 352)
  • BadPixelsPC (352, 512, 128)
  • BadPixelsCS (352, 512, 128) (128, 512, 352)

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@rovensky @schmidtp @hammerd

Edited by Karim Ahmed

Merge request reports