Skip to content

[Fix][DynamicFF] Follow up initial development

Egor Sobolev requested to merge fix/dynamic-flatfield-follow-up into master

Description

Closes #101

This follows up the questions left in the initial development MR !939 (merged).

  • raise error if constants are not found for particular DA. Raise warning instead (according to beamline scientists request)
  • allow to set creation time with parameter
  • use creation time to request actual snapshots of PDUs

In addition to the previous questions:

  • parameter to skip bad frames in characterization

How Has This Been Tested?

Offline using the runs 114 & 193 to test characterization and run 194 to test correction (proposal 6937)

xfel-calibrate DYNAMICFF DARK --in-folder /gpfs/exfel/exp/SPB/202405/p006937/raw --out-folder /home/esobolev/proj/dynamicff-test/dark/runs_114_193/SPB_MIC_HPVX2 --run-high 114 --run-low 193 --report-to /home/esobolev/proj/dynamicff-test/dark/runs_114_193/SPB_MIC_HPVX2-1.pdf --karabo-da HPVX01/1 --no-db-output
xfel-calibrate DynamicFF CORRECT --slurm-partition exfel --slurm-name correct_SPB_DynamicFF_202405_p006937_r0196 --report-to /home/esobolev/proj/dynamicff-test/usr/r0196/SHIMADZU --karabo-da HPVX01/1 HPVX01/2 HPVX01/3 HPVX01/4 --in-folder /gpfs/exfel/exp/SPB/202405/p006937/raw --out-folder /home/esobolev/proj/dynamicff-test/proc/r0196 --karabo-id SPB_MIC_HPVX2 --run 196

Relevant Documents (optional)

Characterization report: SPB_MIC_HPVX2-1.pdf

Correction report: SHIMADZU.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Reviewers

@schmidtp @kluyvert @ahmedk

Edited by Egor Sobolev

Merge request reports