Fix[AGIPD][CORRECT]: Account for a modified file list if skipping correcting any modules. (!1017) · Merge requests · calibration / pycalibration

Karim Ahmed requested to merge fix/missing_constants_for_some_modules_agipd into master May 30, 2024

Description

While working with the test_calcat . Some modules didn't have dark constants (expectedly). This should lead to no corrections for these modules and no bug. That was not the case.

This MR fixes some bugs:

When a module has no dark constants and supposed to not be corrected (karabo_da is modified with removing the module). The file dict should be updated to avoid correcting and reading this module.
If some modules are missing for CALCAT mapping of the corrected detector, ensure these modules are also removed from corrections.

How Has This Been Tested?

Relevant Documents (optional)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited Sep 02, 2024 by Karim Ahmed

Fix[AGIPD][CORRECT]: Account for a modified file list if skipping correcting any modules.