Fix[AGIPD][CORRECT]: Account for a modified file list if skipping correcting any modules.
All threads resolved!
Description
While working with the test_calcat . Some modules didn't have dark constants (expectedly). This should lead to no corrections for these modules and no bug. That was not the case.
This MR fixes some bugs:
- When a module has no dark constants and supposed to not be corrected (karabo_da is modified with removing the module). The file dict should be updated to avoid correcting and reading this module.
- If some modules are missing for CALCAT mapping of the corrected detector, ensure these modules are also removed from corrections.
How Has This Been Tested?
-
TBD
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
assigned to @ahmedk
- Resolved by Karim Ahmed
added 1 commit
- a24b20b7 - fix: Raise warning for skipping das not mapped to detector in CALCAT
added 195 commits
-
a24b20b7...178a5b54 - 193 commits from branch
master
- ec0ed96b - fix(AGIPD)(CORRECT): Account for a modified file list if skipping correcting any modules.
- 06ffeccf - fix: Raise warning for skipping das not mapped to detector in CALCAT
-
a24b20b7...178a5b54 - 193 commits from branch
added Bug label
- Resolved by Karim Ahmed
added 134 commits
-
06ffeccf...1b39698e - 131 commits from branch
master
- 6dc38f56 - fix(AGIPD)(CORRECT): Account for a modified file list if skipping correcting any modules.
- 0e02cbd6 - fix: Raise warning for skipping das not mapped to detector in CALCAT
- aa402a5a - improve the code for filtering available das
Toggle commit list-
06ffeccf...1b39698e - 131 commits from branch
changed milestone to %3.15.2
- Resolved by Karim Ahmed
added 23 commits
-
aa402a5a...4ef21f6e - 19 commits from branch
master
- 0b8e7598 - fix(AGIPD)(CORRECT): Account for a modified file list if skipping correcting any modules.
- 88b6139c - fix: Raise warning for skipping das not mapped to detector in CALCAT
- c2d31297 - improve the code for filtering available das
- 4f058c5d - fix: check wrong da parameter
Toggle commit list-
aa402a5a...4ef21f6e - 19 commits from branch
mentioned in commit 468d49cb
Please register or sign in to reply