Feat[Jungfrau]: Inject CCVs using RESTful API
Description
Inject CCVs without using calibration_client
. This enables more control over injection and better error transparency.
These are the injected CCV report with the current MR: https://internal.xfel.eu/test_calibration/reports/2871
Below is a link to another report trying to reinject the same CCVs.
This MR is addressing this issue:https://git.xfel.eu/calibration/planning/-/issues/182
How Has This Been Tested?
Relevant Documents (optional)
Types of changes
Checklist:
Reviewers
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
added 1 commit
- 55795fd4 - fix: remove unrelated change from constants.py and isort on inject.py
added 45 commits
- 55795fd4...6a6daa6a - 35 earlier commits
- b2fffbf3 - feat: use begin_at_strategy to find prior ccvs
- 822021b1 - fix: store dims not shapes
- f9078835 - fix: in the process of fixing summary chapter for junfrau darks
- 986bbe32 - fix: Fix summary chapter plotting and CCV file access
- f49058e1 - refactor: reduce MR diff by reverting some of function split
- bbdfde7b - fix: remove unused libraries
- 517b14c6 - feat: new functions to load pdus by detector id or identifier and use it in the dark notebook
- 0c7720c8 - feat: Introduce new module for injecting new calibration constant version
- bae8edc6 - reactor: small refactors to injecting and add usage in notebook
- e560ae20 - fix: remove unrelated change from constants.py and isort on inject.py
Toggle commit listadded 18 commits
-
e560ae20...b004dd5e - 15 commits from branch
feat/remove_calibrationDBRemote_usage
- 856827e1 - feat: Introduce new module for injecting new calibration constant version
- 82dbc19a - reactor: small refactors to injecting and add usage in notebook
- 9fbae1ef - fix: remove unrelated change from constants.py and isort on inject.py
Toggle commit list-
e560ae20...b004dd5e - 15 commits from branch
added 1 commit
- be2834b8 - fix: convert dataclass to hashable, keep only reports/set and small fixes for new functions
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
Notes from our meeting related to this MR and injecting CCVs.
- Move get/post requests to calcat_interface2
- No need to use classes after the movement, constants.py can be used now again with modular functions.
- Carefully use
lru_cache
and consider the interactive usage for the API. - untangle this clumsy situation related to
get_ccv_info_from_file
and the need to pass a client. - Try not to strongly depend on the current CalCat's endpoint path state if possible.
added 1 commit
- 9a891382 - refactor: move methods to CALCATAPI and move modules to constants.py
added 1 commit
- 127b7ca3 - test(temporary): add environment variable to test with test_calibration
Please register or sign in to reply