Skip to content
Snippets Groups Projects

Feat[Jungfrau]: Inject CCVs using RESTful API

Merged Karim Ahmed requested to merge feat/inject_ccv_resfulapi into master

Description

Inject CCVs without using calibration_client. This enables more control over injection and better error transparency.

These are the injected CCV report with the current MR: https://internal.xfel.eu/test_calibration/reports/2871

Below is a link to another report trying to reinject the same CCVs.

This MR is addressing this issue:https://git.xfel.eu/calibration/planning/-/issues/182

How Has This Been Tested?

Relevant Documents (optional)

No_caldbremote_jungfrau.pdf Screenshot_from_2024-07-31_18-17-34

Types of changes

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Notes from our meeting related to this MR and injecting CCVs.

    • Move get/post requests to calcat_interface2
    • No need to use classes after the movement, constants.py can be used now again with modular functions.
    • Carefully use lru_cache and consider the interactive usage for the API.
    • untangle this clumsy situation related to get_ccv_info_from_file and the need to pass a client.
    • Try not to strongly depend on the current CalCat's endpoint path state if possible.
  • Karim Ahmed added 1 commit

    added 1 commit

    • 9a891382 - refactor: move methods to CALCATAPI and move modules to constants.py

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 942767b3 - fix: remove unoutdated changes

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • dabe0cd7 - fix: remove unoutdated changes

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • 5287be06 - pep8: add more space between classes

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed added 1 commit

    added 1 commit

    • 127b7ca3 - test(temporary): add environment variable to test with test_calibration

    Compare with previous version

  • Karim Ahmed marked this merge request as ready

    marked this merge request as ready

  • Karim Ahmed changed title from Draft: Feat/inject ccv resfulapi to Feat[Jungfrau]: Inject CCVs using RESTful API

    changed title from Draft: Feat/inject ccv resfulapi to Feat[Jungfrau]: Inject CCVs using RESTful API

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading