feat[PNCCD][Correct]: New corrected data source and link to legacy source
All threads resolved!
All threads resolved!
Description
- Write pnccd data in a separate data source and softlink to the legacy data source.
- Remove the stored raw image in
*/image/data
and store corrected data in*/image/data
instead of*/pixels/data
- Remove the stored gain map duplicated data from the corrected data files.
- Move from
.../CAL/...
to.../CORR/...
by default to match other detectors.
Related to this issue: https://git.xfel.eu/calibration/planning/-/issues/170
How Has This Been Tested?
CORR-R9001-PNCCD01-S00012.h5
+ NEW: INDEX/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/count
+ NEW: INDEX/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/first
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/image
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/mask
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/patterns
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/pixels_classified
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/pixels_cm
+ NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/trainId
- MISSING: INDEX/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/count
- MISSING: INDEX/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/first
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/gain
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/image
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/mask
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/patterns
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels_classified
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels_cm
- MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/trainId
~ CHANGED: METADATA/dataSources/dataSourceId (Value: b'INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data' -> b'INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data')
~ CHANGED: METADATA/dataSources/deviceId (Value: b'SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data' -> b'SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data')
-----------
## Relevant Documents (optional)
<!-- Include any relevant screenshot, elogs, reports, if appropriate. -->
Types of changes
- New feature (non-breaking change which adds functionality)
Checklist:
Reviewers
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
added 10 commits
-
1baac578...1d83b9db - 9 commits from branch
master
- d960fd3f - feat[PNCCD][Correct]: New corrected data source and link to legacy source
-
1baac578...1d83b9db - 9 commits from branch
added Test CAL Data Affected Testing labels
assigned to @ahmedk
added 1 commit
- 914164f7 - move from CAL to CORR for a default output_source_template
- Resolved by Karim Ahmed
added 1 commit
- a1880384 - fix: no need to include raw source or create a symlink to it
- Resolved by Karim Ahmed
- Resolved by Philipp Schmidt
- Resolved by Thomas Kluyver
So for PNCCD anyone using corrected data will have to update their code to the new name straight away?
mentioned in commit d3a6aebe
changed milestone to %3.15.0
Please register or sign in to reply