Skip to content

feat[PNCCD][Correct]: New corrected data source and link to legacy source

Karim Ahmed requested to merge feat/new_pnccd_correct_source into master

Description

  • Write pnccd data in a separate data source and softlink to the legacy data source.
  • Remove the stored raw image in */image/data and store corrected data in */image/data instead of */pixels/data
  • Remove the stored gain map duplicated data from the corrected data files.
  • Move from .../CAL/... to .../CORR/... by default to match other detectors.

Related to this issue: https://git.xfel.eu/calibration/planning/-/issues/170

How Has This Been Tested?

CORR-R9001-PNCCD01-S00012.h5
  + NEW: INDEX/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/count
  + NEW: INDEX/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/first
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/image
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/mask
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/patterns
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/pixels_classified
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/pixels_cm
  + NEW: INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data/trainId
  - MISSING: INDEX/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/count
  - MISSING: INDEX/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/first
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/gain
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/image
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/mask
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/patterns
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels_classified
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/pixels_cm
  - MISSING: INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data/trainId
  ~ CHANGED: METADATA/dataSources/dataSourceId (Value: b'INSTRUMENT/SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data' -> b'INSTRUMENT/SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data')
  ~ CHANGED: METADATA/dataSources/deviceId (Value: b'SQS_NQS_PNCCD1MP/CAL/PNCCD_FMT-0:output/data' -> b'SQS_NQS_PNCCD1MP/CORR/PNCCD_FMT-0:output/data')
-----------
## Relevant Documents (optional)
<!-- Include any relevant screenshot, elogs, reports, if appropriate. -->

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

Reviewers

Edited by Karim Ahmed

Merge request reports

Legal Notice | Contacts