Swap order of dicts for DeepDiff
If there are changes, DeepDiff labels values from the first dict as old_value
and values from the second as new_value
. This meant the reference value was the 'new' one, causing us some confusion.
cc @ahmedk
Merge request reports
Activity
Filter activity
OK, this is the way we expect now:
"root['AGIPD02']['constants']['Noise']['ccv_id']": {'new_value': 202755, 'old_value': 84950}, "root['AGIPD02']['constants']['Noise']['path']": {'new_value': '/gpfs/exfel/d/cal/caldb_store/xfel/cal/agipd-type/agipd_siv1_agipdv11_m314/cal.1714487030.0868747.h5', 'old_value': '/gpfs/exfel/d/cal/caldb_store/xfel/cal/agipd-type/agipd_siv1_agipdv11_m314/cal.1627676400.0333762.h5'},
mentioned in commit 2a7962c5
Thanks @kluyvert, I think you are good to merge. I guess for now the only solution is for me to update the reference data.
I will leave this question for tomorrow to confirm in case anyone have another opinion
changed milestone to %3.15.0
Please register or sign in to reply