[TIMEPIX] Bug Fix: Allow manual specification of the proposal
Description
This fix makes the proposal
input argument work properly. Previously it was ignored building the path for the timewalk correction files. However when providing custom in_folder
the proposal auto-detection does not work properly anymore.
How Has This Been Tested?
Tested with Timepix4 data:
/gpfs/exfel/exp/SQS/202425/p008176/usr/Software/pycalibration/.venv/bin/python -m xfel_calibrate.calibrate timepix CORRECT --no-cluster --request-time 2024-08-08T04:52:23.829457 --report-to /gpfs/exfel/exp/SQS/202425/p008176/scratch/tpx4_xd/test//Reports/r0012/SQS_EXP_TIMEPIX_correct_008176_r0012_20240808_045223_829457 --karabo-da DA00 --in-folder /gpfs/exfel/exp/SQS/202425/p008176/scratch/tpx4_xd/test//raw --out-folder /gpfs/exfel/exp/SQS/202425/p008176/scratch/tpx4_xd/test//proc/r0012 --karabo-id SQS_EXP_TIMEPIX --in-fast-data SQS_EXP_TIMEPIX/DET/TIMEPIX4:daqOutput.chip0 --out-device-id SQS_EXP_TIMEPIX/CAL/TIMEPIX4 --out-fast-data SQS_EXP_TIMEPIX/CAL/TIMEPIX4:daqOutput.chip0 --run 12 --proposal p008176
(as part of a longer analysis script that first produces the raw data:)
/gpfs/exfel/exp/SQS/202425/p008176/usr/Software/tempus_2_extradata.py 12 12
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Merge request reports
Activity
requested review from @schmidtp
assigned to @bjoerns
I used this opportunity to double-check on the webservice which arguments are passed by default, but
proposal
is not among them (I think!). It seems like we ignored it before this MR, so we should keep in mind it will not properly work when queueing via the webservice.Since it will be replaced by CalCat anyway and serves a workaround right now, LGTM.
@ahmedk FYI
mentioned in commit e5367add
changed milestone to %3.15.1