[AGIPD] [PC] various fixes in PC notebooks
All threads resolved!
All threads resolved!
Description
This MR fixes several issue in AGID PC notebooks, namely:
- fixing UnboundLocalError for a variable in processing notebook leading to plotting failure,
- fixing retrieval of previous constants to be done for all modules,
- fixing buggy indexing of modules for plotting summary plots.
- changing default concurrency from 16 to a function evaluating number of det. instance modules (same way as for darks).
- fixing error in plotting due to matplotlib upgrade.
How Has This Been Tested?
Testing data and reports available here: /gpfs/exfel/exp/MID/202431/p900465/scratch/rovensky/PC_test/202cells0.5MHz_gs0_20clk Test data for SM: /gpfs/exfel/exp/HED/202430/p900438/scratch/rovensky/pc
Relevant Documents (optional)
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
Reviewers
Edited by Vratko Rovensky
Merge request reports
Activity
Filter activity
added 1 commit
- d78d1c30 - Changing default concurrency for PC, fixing plotting issue due to matplotlib upgrade
- Resolved by Vratko Rovensky
- Resolved by Vratko Rovensky
Beside my suggestion, LGTM
added 52 commits
-
d78d1c30...432c4c57 - 50 commits from branch
master
- 0561a6f4 - Removing first_run parameter.
- 73a31ec6 - Merge branch 'master' into fix/agipdPC_fixes
-
d78d1c30...432c4c57 - 50 commits from branch
mentioned in commit 2ca248e8
Please register or sign in to reply