Skip to content
Snippets Groups Projects

[AGIPD] [PC] various fixes in PC notebooks

Merged Vratko Rovensky requested to merge fix/agipdPC_fixes into master
All threads resolved!

Description

This MR fixes several issue in AGID PC notebooks, namely:

  • fixing UnboundLocalError for a variable in processing notebook leading to plotting failure,
  • fixing retrieval of previous constants to be done for all modules,
  • fixing buggy indexing of modules for plotting summary plots.
  • changing default concurrency from 16 to a function evaluating number of det. instance modules (same way as for darks).
  • fixing error in plotting due to matplotlib upgrade.

How Has This Been Tested?

Testing data and reports available here: /gpfs/exfel/exp/MID/202431/p900465/scratch/rovensky/PC_test/202cells0.5MHz_gs0_20clk Test data for SM: /gpfs/exfel/exp/HED/202430/p900438/scratch/rovensky/pc

Relevant Documents (optional)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@ahmedk @jsztuk

Edited by Vratko Rovensky

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vratko Rovensky changed the description

    changed the description

  • Vratko Rovensky resolved all threads

    resolved all threads

  • Vratko Rovensky added 52 commits

    added 52 commits

    Compare with previous version

  • Vratko Rovensky resolved all threads

    resolved all threads

  • mentioned in commit 2ca248e8

  • Please register or sign in to reply
    Loading