Fix: Modified and corrected the pnccd dark notebook.
@ahmedk Hi Karim,
I have corrected pnCCD dark notebook so that it has the correct blocksize (verified by Steffen), correct common mode definition and it sends the correct offsetmap into the database. I also added a bunch of diagnostic tables and graphs. Misha knows about these issues but his name is not listed under the "Assignees" so I had to add you instead. Sorry.
Cheers, Kiana
Merge request reports
Activity
Hi Misha. Yes everything even bias voltage is hard coded for pnCCD. I don't know why this is the case. Perhaps no one had the time to have karabo devices that would read these values automatically. But I have spoken to Steffen and Controls people and they will start working on it as of yesterday. Once they make Karabo devices that can read these values and incorporate the values into DAQ, I will modify the notebook so that these parameters are read automatically. Cheers, Kiana
mentioned in merge request !239 (merged)
Notebooks runs and give some reasonable (for the first glance) result (see report PNCCD_dark.pdf )
Without suggested changes offset map is completely meaningless. Therefore I would suggest to consider this MR as a fix. Questions, if further modifications are required may be clarified later.
I modified a flag push to DB to False.
Code refactoring, I guess, was performed bu automatic pep8 formatter.
Edited by Mikhail Karnevskiy- Resolved by Mikhail Karnevskiy
- Resolved by Mikhail Karnevskiy
- Resolved by Mikhail Karnevskiy
67 "import copy\n", 68 "import h5py\n", 69 "import datetime\n", 70 "import warnings\n", 71 "warnings.filterwarnings('ignore')\n", 72 "\n", 73 "import numpy as np\n", 74 "import matplotlib.pyplot as plt\n", 75 "%matplotlib inline\n", 76 "from iminuit import Minuit\n", 77 "from prettytable import PrettyTable\n", 78 "from IPython.display import display, Markdown\n", 79 79 "\n", 80 "from iCalibrationDB import ConstantMetaData, Constants, Conditions, Detectors, Versions\n", 81 "from iCalibrationDB.detectors import DetectorTypes\n", 82 "import XFELDetAna.xfelprofiler as xprof\n", Hi Kiana, I already fixed them. Thank you.
I have a question concerning CM correction algorithm. Do you know the origination of peak at 0?
added 24 commits
-
aa414f51...795bcece - 23 commits from branch
master
- 498cc754 - modified and corrected the pnccd dark notebook.
-
aa414f51...795bcece - 23 commits from branch
added 1 commit
- 1fb20397 - modified and corrected the pnccd dark notebook.
mentioned in commit c4d0daf8