Skip to content
Snippets Groups Projects

Fix: Modified and corrected the pnccd dark notebook.

Merged Kiana Setoodehnia requested to merge Kianas_Corrections into master
1 unresolved thread

@ahmedk Hi Karim,

I have corrected pnCCD dark notebook so that it has the correct blocksize (verified by Steffen), correct common mode definition and it sends the correct offsetmap into the database. I also added a bunch of diagnostic tables and graphs. Misha knows about these issues but his name is not listed under the "Assignees" so I had to add you instead. Sorry.

Cheers, Kiana

Edited by Mikhail Karnevskiy

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed
    Karim Ahmed @ahmedk started a thread on commit a0b74ae9
  • 67 "import copy\n",
    68 "import h5py\n",
    69 "import datetime\n",
    70 "import warnings\n",
    71 "warnings.filterwarnings('ignore')\n",
    72 "\n",
    73 "import numpy as np\n",
    74 "import matplotlib.pyplot as plt\n",
    75 "%matplotlib inline\n",
    76 "from iminuit import Minuit\n",
    77 "from prettytable import PrettyTable\n",
    78 "from IPython.display import display, Markdown\n",
    79 79 "\n",
    80 "from iCalibrationDB import ConstantMetaData, Constants, Conditions, Detectors, Versions\n",
    81 "from iCalibrationDB.detectors import DetectorTypes\n",
    82 "import XFELDetAna.xfelprofiler as xprof\n",
  • beside the few comments, LGTM.

  • added 1 commit

    Compare with previous version

  • @setoodeh

    I have a question concerning CM correction algorithm. Do you know the origination of peak at 0?

  • Author Contributor

    No, Misha. I talked to you on the phone about this issue. Thank you very much and thank you Karim also for your time and help.

    Best, Kiana

  • added 24 commits

    Compare with previous version

  • added 1 commit

    • 1fb20397 - modified and corrected the pnccd dark notebook.

    Compare with previous version

  • mentioned in commit c4d0daf8

  • Please register or sign in to reply
    Loading