Skip to content
Snippets Groups Projects

FIX: Plot caption and bpx table

Merged Karim Ahmed requested to merge fix/report_infos into master
1 unresolved thread

This is a fix for some of the shown info in the dark report. Also I did a validation that the gain_setting is the same for all of the files. This requirement was generated when I put by mistake wrong 3 runs for generating the dark constants.

@karnem

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
173 173 " gain_setting = None\n",
174 174 " else:\n",
175 175 " try:\n",
176 " gain_setting = get_gain_setting(control_fname, h5path_ctrl)\n",
176 " # extract gain setting and validate that all runs have the same setting\n",
177 " gsettings = []\n",
178 " for r in runs:\n",
179 " control_fname = '{}/r{:04d}/RAW-R{:04d}-{}-S00000.h5'.format(in_folder, r, r,\n",
180 " karabo_da_control)\n",
181 " gsettings.append(get_gain_setting(control_fname, h5path_ctrl))\n",
182 " if not all(g == gsettings[0] for g in gsettings):\n",
183 " raise ValueError(f\"Different gain settings for the 3 input runs {gsettings}\")\n",
  • Apart small comment LGTM.

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • merged

  • Karim Ahmed mentioned in commit df1d8290

    mentioned in commit df1d8290

  • Please register or sign in to reply
    Loading