update_config with new mapping
@karnem MR with changes to webservice to have the update config service working properly
Merge request reports
Activity
For my understanding this is not a general purpose tool, which we will develop in a future but a temporary solution until proper functionality will be introduced in the MDC. Therefore I would simplify interface to reduce possibility to destroy calibration configuration:
- Remove choice of instruments and deduce SPB or MID based on karabo-id
- Remove tasks: we provide configuration for correction only
- Add help message to
--apply
Done
Remove choice of instruments and deduce SPB or MID based on karabo-id
instrument choices were removed only CALLAB was left and instrument argument has been removed from required arguments as it is derived by default from the karabo_ids
Remove tasks: we provide configuration for correction only
tasks have been removed. correct is used by default.
Add help message to
--applyThe help message is added.
@jsztuk mentioned that the instruments have already requested it, so I will work on including it here in this MR.
Edited by Karim Ahmed
801 809 ).split() 802 810 803 811 cmd = await parse_config(cmd, dconfig) 804 812 ret = await run_action(job_db, cmd, mode, proposal, runnr, what kind of configuring problem? would they already get catched in exceptions? for example if given
--max-pulses ["1,21,1"]which is wrong an exception will be made. what will be in ret at that point?Edited by Karim Ahmed
63 53 64 54 if detector is not None: 55 for option, typ in available_options[detector].items(): 56 if typ == list: 57 nargs = '+' 58 else: 59 nargs = None 60 parser.add_argument(f"--{option}", type=typ, nargs=nargs) 65 # Avoid erros when karabo_id not yet given through the command line. 66 if karabo_id is not None: 67 for det, val in available_options[karabo_id][0].items(): 68 if val['typ'] == bool: 69 bool_keys.append(det) 70 71 for b in bool_keys: changed this line in version 9 of the diff
Because bool keys are not only used for adding "no" to the available booleans, it is perserving the bool keys before any additions. as there might be a --no-bool in the future in the exposed parameters
Edited by Karim Ahmed
mentioned in commit b477580e
