Skip to content
Snippets Groups Projects

Feat/reproducibility

Merged Steffen Hauf requested to merge feat/reproducibility into master

@karnem, @amunnich, @samartse, @qingtian, and FYI: @fangohr

This adds basic consistency testing for the correction notebooks of AGIPD and LPD, with reports also building into the documentation, see e.g:

https://in.xfel.eu/readthedocs/docs/european-xfel-offline-calibration/en/feat-reproducibility/test_results.html

and

https://in.xfel.eu/readthedocs/docs/european-xfel-offline-calibration/en/feat-reproducibility/testing.html

for a summary of how things work.

Note that in the documentation example, I've included quite a few failure cases, which are not part of this commit into the artefacts directory, these are removed for the latest commit.

Next steps after this is review and merged:

  • add tests for Jungfrau and FastCCD correction notebooks
  • add tests for characterisation notebooks. We should likely think about mock calibration database handling there, which resolves requests to always the same data, and provides verification for submissions to it.

Setting to WIP until the two update MRs are merged

Edited by Steffen Hauf

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
2 import unittest
3
4 import numpy as np
5 import xmlrunner
6
7 from correction_base import CorrectionTestBase, args, get_artefact_dir
8
9
10 class TestAGIPDCorrection(CorrectionTestBase, unittest.TestCase):
11 detector = "AGIPD"
12 task = "CORRECT"
13 parms = {"in-folder": "/gpfs/exfel/exp/SPB/201831/p900039/raw/",
14 "run": 412,
15 "out-folder": "/gpfs/exfel/data/scratch/haufs/test/",
16 "calfile": "/gpfs/exfel/data/scratch/haufs/agipd_on_demand"
17 "/agipd_store.h5",
  • Steffen Hauf
  • Steffen Hauf added 1 commit

    added 1 commit

    • 8cea8b1b - Add karabo data self validation to tests

    Compare with previous version

  • Andrey Samartsev
  • 4 4 import numpy as np
    5 5 import xmlrunner
    6 6
    7 from correction_base import CorrectionTestBase, args, get_artifact_dir
    7 from correction_base import CorrectionTestBase, args, get_artefact_dir
  • Author Maintainer

    Thanks for review!

  • Steffen Hauf added 1 commit

    added 1 commit

    Compare with previous version

  • Steffen Hauf changed target branch from upd/lpd to master

    changed target branch from upd/lpd to master

  • Author Maintainer

    @karnem could you give this a review?

  • Few python packages have been missing: xmlrunner gitpython karabo_data

  • Steffen Hauf added 1 commit

    added 1 commit

    Compare with previous version

  • Author Maintainer

    I just tried on a fresh Karabo-2.3 install and did not have any problems. Could you try in that setup with the requirements.txt I've updated in the last commit.

  • Python package sklearn is also missing and required.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading