In this MR, I've made modifications regarding the way the acquisition rate is calculated, as part of the Mini Half epic (calibration-workshop issue #177
How Has This Been Tested?
It's been tested by running the notebook against DETLAB data. Jola approved the resulting report resulting from this script:
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
In cal_tools.cal_tools.tools.agipdlib, I extensively modified get_acq_rate to be able to get the acquisition rate from slow data, the MDL FPGA_COMP device.
I've updated the interface such that it first tries to get the information from slow data, if possible, or then resorts to calculating it from fast data.
As such, all AGIPD notebooks have to have be updated. Which I will do once the report has been approved.
Checklist:
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Having talked offline with @ahmedk , we discussed the usage of type hinting.
We're thinking of trialling it, as a number of functions have cryptic parameters.
Cyril Danilevski authored