[AGIPD] [SlopesPC] use send_to_db
All threads resolved!
All threads resolved!
Summary
- There was a bug in the SlopesPC that it was hardcoded to inject constants only for the SPB physical modules (AGIPD1M1).
- Sphinx tag updated to use feature for wrapping long parsed-literal text in .rst
Steps to reproduce
- Running
Chracterize_AGIPD_Gain_PC_NBC.ipynb
with parameter inputinstrument = "MID"
- Trying to inject constants with non-available conditions in the database, will show part of the error message in a pdf report.
What is the current bug behavior?
- After creating constants from MID raw data it is injected to the database for the wrong 16 modules in SPB, not MID
- CalibrationDBRemote sends back long messages in case of errors related to the database which will not be totally exposed in the pdf report as it is written in
parsed-literal
section in .rst without proper spaces
Relevant reports:
- Difference can be shown at the parts for visualising feedback for injecting constants to the database
-
Before fix: dark_900170_r134_200912_082137.pdf
-
After fix:CharacterizeAGIPDPulseCapacitorData.pdf
Possible fixes
Lines responsible for this bug
Edited by Karim Ahmed
Merge request reports
Activity
Filter activity
added 14 commits
-
61c8469c...039f3933 - 12 commits from branch
master
- 8ffcd0c3 - use send_to_db
- 9b6721fd - fix conditions recreation
-
61c8469c...039f3933 - 12 commits from branch
added 1 commit
- e9ed8a8f - use updated sphinx for wrapping long err strings
added 1 commit
- 54b42776 - use updated sphinx for wrapping long err strings
- Resolved by Cyril Danilevski
It seems to me that most of the changes are related to the metadata, whose setting up has been superseeded by
send_to_db
, in which this metadata is created.Maybe a little nitpick is that the error can be printed by
print(e)
?If I get this right, then it's LGTM.
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
mentioned in commit f85a6926
Please register or sign in to reply