Skip to content
Snippets Groups Projects

[AGIPD] [SlopesPC] use send_to_db

Merged Karim Ahmed requested to merge fix/SlopesPC_AGIPD_db_inj into master
All threads resolved!

Summary

  1. There was a bug in the SlopesPC that it was hardcoded to inject constants only for the SPB physical modules (AGIPD1M1).
  2. Sphinx tag updated to use feature for wrapping long parsed-literal text in .rst

Steps to reproduce

  1. Running Chracterize_AGIPD_Gain_PC_NBC.ipynb with parameter input instrument = "MID"
  2. Trying to inject constants with non-available conditions in the database, will show part of the error message in a pdf report.

What is the current bug behavior?

  1. After creating constants from MID raw data it is injected to the database for the wrong 16 modules in SPB, not MID
  2. CalibrationDBRemote sends back long messages in case of errors related to the database which will not be totally exposed in the pdf report as it is written in parsed-literal section in .rst without proper spaces

Relevant reports:

  1. Difference can be shown at the parts for visualising feedback for injecting constants to the database

Possible fixes

Lines responsible for this bug

  1. https://git.xfel.eu/gitlab/detectors/pycalibration/blob/2.8.7-temporary/notebooks/AGIPD/Chracterize_AGIPD_Gain_PC_NBC.ipynb#L1454-1456 and https://git.xfel.eu/gitlab/detectors/pycalibration/blob/2.8.7-temporary/notebooks/AGIPD/Chracterize_AGIPD_Gain_PC_NBC.ipynb#L1478-1480

@danilevc @kamile

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Thomas Kluyver
  • Karim Ahmed added 1 commit

    added 1 commit

    • d75e719e - update sphinx.quickstart cmd

    Compare with previous version

  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Thanks for the review!

  • merged

  • Karim Ahmed mentioned in commit f85a6926

    mentioned in commit f85a6926

  • Please register or sign in to reply
    Loading