Skip to content
Snippets Groups Projects

[AGIPD] [Reports] Add mini half figures

Merged Cyril Danilevski requested to merge feat/mini_half_plotting into master
1 unresolved thread

Description

This adds the geometry figure that are used in reports to highlight which module is a given chapter of a report about.
This is still a WIP, as we need a new release of extra_geom.

How Has This Been Tested?

This currently has been tested with a notebook calling directly show_processed_modules:

from cal_tools.plotting import show_processed_modules
 
show_processed_modules(dinstance='AGIPD500K', constants={}, mnames=['Q1M1'], mode='processed')  # no noise
show_processed_modules(dinstance='AGIPD500K', mnames['Q2M1'], mode='position')

I still want to generate a report from darks processing, which I'll attach when available.

Relevant Documents (optional)

In processed mode (no Noise in constants):
image

In position mode:
image

Types of changes

  • New feature (non-breaking change which adds functionality)

Reviewers

@ahmedk @tmichela @kamile

Edited by Cyril Danilevski

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Michelat
  • added 1 commit

    • 5ae7754c - [AGIPD][Darks] Reinstate overall module summary fro mini-half

    Compare with previous version

  • added 1 commit

    • a17df915 - [AGIPD][Darks] Reinstate overall module summary for mini-half

    Compare with previous version

  • added 1 commit

    • f4871264 - Fix legend in processed modules figure

    Compare with previous version

  • Here's a report generated from HED darks: agipdcharacterizedarkimages.pdf

    It was generated using this branch, extra_geom on master, and these arguments:

    xfel-calibrate AGIPD DARK \
        --slurm-mem 750 \
        --slurm-name darks_mini_half \
        --report-to /gpfs/exfel/data/scratch/danilevc/out/mini_half_test \
        --receiver-id {}CH0 \
        --karabo-id-control HED_EXP_AGIPD500K2G \
        --karabo-da-control AGIPD500K2G00 \
        --h5path-ctrl /CONTROL/{}/MDL/FPGA_COMP \
        --in-folder /gpfs/exfel/exp/HED/202031/p900174/raw/ \
        --out-folder /gpfs/exfel/data/scratch/danilevc/out/mini_half_test/runs_r0010_r0011_r0012 \
        --karabo-id HED_DET_AGIPD500K2G \
        --run-high 10 \
        --run-med 11 \
        --run-low 12 \
        --modules 0,1,2,3,4,5,6,7 \
    
  • Cyril Danilevski resolved all discussions

    resolved all discussions

  • 281 # Create a dict that contains the range of tiles, in the figure,
    282 # that belong to a module.
    283 ranges = dict()
    284 count = 0
    285 for quadrant in range(1, 3):
    286 for module in range(1, 5):
    287 ranges[f'Q{quadrant}M{module}'] = [count, count + 8]
    288 count += 8
    289
    290 geom = AGIPD_500K2GGeometry.from_origin()
    291 ax = geom.inspect()
    292
    293 ax.set_title('') # Cannot remove title
    294 ax.set_axis_off()
    295 ax.get_legend().set_visible(False)
    296 ax.figure.set_dpi(100)
  • Cyril Danilevski unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Cyril Danilevski changed the description

    changed the description

  • I decided to keep the poorly contrasting colours for now.
    We plan to make use of extra_geom for other detectors as well. As such, we'll make a saner colour scheme when updating all figures :)

    Edited by Cyril Danilevski
  • added 1 commit

    • 14bc5a8d - Update extra_geom requirement tag

    Compare with previous version

  • Boom! Done!

  • added 1 commit

    • 32785a46 - Apply suggestion to cal_tools/cal_tools/plotting.py

    Compare with previous version

  • Thank you!

  • mentioned in commit 6eb9b438

  • Hugo Santos removed milestone

    removed milestone

  • Please register or sign in to reply
    Loading