Skip to content

Make use of extra geom for report figures

Cyril Danilevski requested to merge feat/extra_geom_figures into master

Description

In this PR, we introduce the usage of EXtra-geom for rendering processed modules of all detectors, instead of some mystery code.

Yes, I am a savage, and yes, I am using the geometry from the tests folder 👍

How Has This Been Tested?

This can be tested so:

import pytest
from cal_tools.plotting import show_processed_modules
mnames = ['Q1M1']

for detector in ('DSSC', 'AGIPD1M2', 'AGIPD500K', 'LPD'):
    show_processed_modules(detector, mnames=mnames, constants={}, mode='processed')

with pytest.raises(ValueError) as err:
    show_processed_modules('LDP', mnames=mnames, constants={}, mode='processed')
assert err.value.args[1] == 'LDP'

Relevant Documents (optional)

DSSC

image

AGIPD

image

Mini Half

image

LPD

image

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the code style of this project.

Reviewers

@ahmedk @kamile @tmichela @kluyvert

Edited by Cyril Danilevski

Merge request reports