Skip to content
Snippets Groups Projects

Fix/3.0.0 test02 fixes

Merged Karim Ahmed requested to merge fix/3.0.0_test02_fixes into master
All threads resolved!

Summary:

This is a MR for some of the bugs I observed while testing tag 3.0.0_test02 on xcaltst@max-exfl017

  1. DSSC noise map is 4 dimensions not 5 as LPD and AGIPD
  2. JF bad pixels heatmap didn't have the name of the cell on the title of the plots.
  3. capacitor_setting should not be required as we don't pass the value from configurations(at the moment it is always 5). The issue appeared now as we weren't using , required feature before in xfel_calibrate

Reviewers:

@danilevc @kamile

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Cyril Danilevski
  • Karim Ahmed added 1 commit

    added 1 commit

    • a7e152f9 - Apply suggestion to cal_tools/cal_tools/plotting.py

    Compare with previous version

  • All right, LGTM. But please, don't work over the weekend, it makes me look lazy.

  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Karim Ahmed
  • Karim Ahmed added 1 commit

    added 1 commit

    • 31f6503e - Apply suggestion to cal_tools/cal_tools/plotting.py

    Compare with previous version

  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Thanks for the review

  • merged

  • Karim Ahmed mentioned in commit 76eafb11

    mentioned in commit 76eafb11

  • Please register or sign in to reply
    Loading