Skip to content

[Dark Request]Fix karabo da typing

Cyril Danilevski requested to merge fix/dark_request_karabo_da into master

Description

This fixes an issue where the karabo-da parameter was not fed correctly to the xfel-calibrate command, when called via MyMDC.
Previously, karabo-da was passed as ['JNGFR01, JNGFR02'], which is a list of one string, whereas notebooks expect ['JNGFR01', 'JNGFR02'], a list of n detector modules.

This also fixes a forgotten f-string.

How Has This Been Tested?

This was tested with the test MyMDC installation at https://in.xfel.eu/test_metadata/proposals/259#proposal-calibration, rid 281.

Relevant Documents (optional)

The resulting report is available at /gpfs/exfel/d/cal_tst/caldb_store/xfel/reports/CALLAB/FXE_XAD_JF1M/dark/dark_900113_r9999_r9998_r9997_210210_115928.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Reviewers

@ahmedk @hammerd

Merge request reports