Skip to content
Snippets Groups Projects

Fix/pre commit isort

Merged Robert Rosca requested to merge fix/pre-commit-isort into master

Description

Applies isort fixes for pre-commit checks so that those stop being a source of errors in the future.

Marked as WIP as this requires !417 (merged) to be merged first. I'll rebase (if needed) once that's done.

First step of #36

Ran echo 'nbqa-isort isort' | xargs -n 1 pre-commit run --all-files

How Has This Been Tested?

This change only does:

  • nbqa-isort
  • isort

Which do modify code, however they only re-order the imports. Additionally, the check-ast step of the pre-commit checks will ensure that we still have valid python code.

Relevant Documents (optional)

Types of changes

Formatting fixes

Checklist:

  • My code follows the code style of this project.

Reviewers

@danilevc @ahmedk @hammerd

Edited by Robert Rosca

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading