Use asyncio subprocess interface in webservice code

Description

Using the blocking subprocess module in async code means stopping everything else while a subprocess runs. The equivalent asyncio interfaces allow other tasks to continue. This is a minor issue, as we're not using long-running subprocesses, but it cleans up some FIXMEs.

How Has This Been Tested?

It hasn't. I don't actually know how to get it set up to test. :-( Followed instructions from @danilevc to run it as xcaltst on max-exfl017 and trigger recalibration of some CALLAB data.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.

Reviewers

@danilevc @hammerd @ahmedk

added 1 commit

• 5df5e468 - Add the missing await

Compare with previous version

yay! It's looking good.
If that's fine with you, I could set it up on xcaltst@max-exfl017 and do a few requests using CALLAB data from the test metadata catalog.

This is done by going to xcaltst@max-exfl017, and doing:

ssh xcaltst@max-exfl017
cd /home/xcaltst/pycalibration
git checkout /home/xcaltst/pycalibration
ps aux | grep webservice/webservice.py | awk '{ print $2}' | xargs kill
source /home/xcaltst/pycalibration_venv/bin/activate
/home/xcaltst/pycalibration_venv/bin/python /home/xcaltst/pycalibration/webservice/webservice.py --mode prod --logging INFO --config-file /home/xcaltst/pycalibration/webservice/webservice.yaml

added 2 commits

• 72e8daf1 - Add another missing await
• 1f64088b - Add unit test for wait_on_transfer

Compare with previous version

added 2 commits

• 4858e3e4 - isort test_webservice.py
• f657691e - pytest-asyncio needs a newer version of pytest

Compare with previous version

Thanks @danilevc. I'll try that after lunch.

added 1 commit

• 563c46f1 - Quote argument with > in

Compare with previous version

I guess I'm meant to use some other copy of the yaml config, not the one that's checked into the repo, because that seems to be configured to use production servers & locations rather than test ones. I see one at ~/webservice_save.yaml, and one at ~/pycalibration/save/webservice.yaml - is it either of those?

added 1 commit

• 8dad1e5c - Move sleep after first getfattr check

Compare with previous version

added 1 commit

• a2a2a659 - Fix retcode -> stdout

Compare with previous version

added 1 commit

• 9cc69c0c - Fix test on Python 3.6

Compare with previous version

I moved the sleep to after the first check of the run folder migration info. This probably means a tiny bit of extra work for runs that are still being migrated, but if you request recalibration for data already on Maxwell, it avoids an unnecessary 10 second wait.

changed the description

Thanks! This is working as expected.

I welcome the improvements on the loop logic!

LGTM

Thanks Cyril!

merged

mentioned in commit 51adb1de