Fix import * in agipdlib
2 unresolved threads
2 unresolved threads
Description
Going through a few CI logs, I noticed that cal_tools/cal_tools/agipdlib.py was flagged a few times due to its from agipdutils import *.
This fixes that, as well as a few other pep8 violations.
No logic changes were introduced.
How Has This Been Tested?
This was tested by running python agipdlib.py to ensure that the file can be loaded fine.
Types of changes
- Code cleanup
Checklist:
- My code follows the code style of this project.
Reviewers
Merge request reports
Activity
Filter activity
flake8likes it. I like it. LGTMIn my experience, it reliabily detects when you're missing a symbol.
Edited by Philipp Schmidt203 210 self.rng_pulses = max_pulses 204 211 # avoid list(range(*[0]])) 205 212 self.pulses_lst = list(range(*max_pulses)) \ 206 if not (len(max_pulses) == 1 and max_pulses[0] == 0) else max_pulses #noqa 213 if not (len(max_pulses) == 1 and max_pulses[0] == 0) else max_pulses # noqa 
That's okay.
The whole line is 80 characters, barely triggering pep8. But it's so because of the line break.
The whole thing could be:
But i did not want to touch the logic in this MR
mentioned in commit 429d7e2a
Please register or sign in to reply