Skip to content
Snippets Groups Projects

[DARKS] Saving detector modules mapping in calibrationMetadata YAML file to use for summary modular notebook

Merged Karim Ahmed requested to merge fix/summary_modular_notebook into master

The summary notebook for modular detectors was still using old mapping code to get the physical name from the hardcoded SW in cal_db_interactive.

This MR updates the notebook along with all three dark notebooks for AGIPD, LPD, and DSSC.

Description

As we have CalibrationMetadata YAML by default. The dark notebooks create a module_mapping.yml for each module.

Then the overall notebook will read the mapping and collect them in the CalibrationMetadata YAML file as below and use them to open local constants and create plotting comparisons between new and previous versions.

"modules_mapping": {
    "Q1M1": "AGIPD_....._M315, 
     .....
}

There are more improvements needed (not saving pre-existing constants locally). But I have reduced changes to the bare minimum for releasing the fix soon.

How Has This Been Tested?

AGIPD:
xfel-calibrate agipd DARK \
--cal-db-interface tcp://max-exfl016:8015#8044 \
--concurrency-par karabo_da \
--karabo-da AGIPD00 AGIPD01 AGIPD02 AGIPD03 AGIPD04 AGIPD05 \
AGIPD06 AGIPD07 AGIPD08 AGIPD09 AGIPD10 \
AGIPD11 AGIPD12 AGIPD13 AGIPD14 AGIPD15 \
--receiver-id {}CH0 \
--karabo-id-control SPB_IRU_AGIPD1M1 \
--karabo-da-control AGIPD1MCTRL00 \
--h5path-ctrl /CONTROL/{}/MDL/FPGA_COMP \
--mem-cells 0 --thresholds-offset-hard 0 0 \
--in-folder /gpfs/exfel/exp/SPB/202130/p900188/raw \
--out-folder /gpfs/exfel/data/scratch/ahmedk/test/fixed_gain/SPB_summary_fix2 \
--karabo-id SPB_DET_AGIPD1M-1 \
--operation-mode ADAPTIVE_GAIN \
--run-high 302 --run-med 303 --run-low 304\
LPD and DSSC:

Already written configs in the first cell were used to test with xfel-calibrate command.

Relevant Documents (optional)

AGIPDCharacterizeDarkImages.pdf

DSSCCharacterizeDarkImages.pdf

LPDOffset_NoiseandDeadPixelsCharacterization.pdf

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@calibration

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed resolved all discussions

    resolved all discussions

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Karim Ahmed changed title from WIP: [DARKS]saving detector mapping in calibrationMetadata YAML file to use for summary modular notebook to [DARKS] Saving detector modules mapping in calibrationMetadata YAML file to use for summary modular notebook

    changed title from WIP: [DARKS]saving detector mapping in calibrationMetadata YAML file to use for summary modular notebook to [DARKS] Saving detector modules mapping in calibrationMetadata YAML file to use for summary modular notebook

  • Karim Ahmed changed the description

    changed the description

  • assigned to @ahmedk

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed changed the description

    changed the description

  • Karim Ahmed added 1 commit

    added 1 commit

    • 1fc953b9 - adding multiple yaml for module mapping to avoid yaml edit collision

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    • bf018998 - nbstripout and remove CalibrationMetadata import

    Compare with previous version

  • Karim Ahmed changed the description

    changed the description

  • Excuse the extra refactoring related to removing notebooks output. this is related to trying and fix one warning. But it seems there are many which shouldn't be addressed now as the plan is to merge this next Tuesday if it was ready.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading