[AGIPD][DARK] Correctly retrieve old constants for comparison
Part of https://git.xfel.eu/gitlab/calibration/planning/issues/56
This merge request is way longer than it should be because I messed up when merging https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/478 - I developed that one against https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/465 and I forgot to switch when merging. So https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/465 was merged into master and then https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/478/diffs was merged into https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/465, never reaching master.
The plots were "fortunately" broken anyway by the erroneous old constant retrieval which is what this MR is actually supposed to fix. I've added comments to point out the two actual new things in this MR. The changes from https://git.xfel.eu/gitlab/detectors/pycalibration/merge_requests/478/diffs were reasonably tested back when I originally intended to merge it.
Merge request reports
Activity
added 1 commit
- b1a8e0a7 - Removing print from function going in process pool
189 192 "print(f\"Detector instance {dinstance}\")" 190 193 ] 191 194 }, 195 { 196 "cell_type": "code", 197 "execution_count": null, 198 "metadata": {}, 199 "outputs": [], 200 "source": [ 201 "timestamp_before_processing = datetime.now().isoformat()" changed this line in version 4 of the diff
added 1 commit
- 088a0cc4 - Use prior_in_time with offset from creation_time instead
666 664 " # TODO: Set db_module to \"\" by default in the first cell\n", 667 665 "\n", 668 666 " data, mdata = get_from_db(\n", 669 " karabo_id,\n", 670 " qm_dict[qm][\"karabo_da\"],\n", 667 " karabo_id=karabo_id,\n", 668 " karabo_da=qm_dict[qm][\"karabo_da\"],\n", 671 669 " constant=dconst,\n", 672 670 " condition=condition,\n", 673 671 " empty_constant=None,\n", 674 672 " cal_db_interface=cal_db_interface,\n", 675 " creation_time=creation_time,\n", 673 " creation_time=creation_time-timedelta(seconds=1),\n", Hi @maial,
Is this how it meant to be or it is supposed to be only (<)
added 1 commit
- 0261705f - Revert support for snapshot_at in get_from_db
added 1 commit
- e47fd2dd - Apply suggestion to notebooks/generic/overallmodules_Darks_Summary_NBC.ipynb
added 1 commit
- 8e40bd2f - Add comment warning to use local_output for summary
enabled an automatic merge when the pipeline for 8e40bd2f succeeds
mentioned in commit c66ee33f
