Try to make pre-commit pass

Checks like this can only be useful if we expect them to pass - checks that always fail are a waste of time and electricity.

I've applied the isort changes, because these are relatively small and simple. The other checks that are failing on MR !499 (merged) I have just removed, because fixing across the repo required massive changes. We can easily add them back if we decide to, for instance, make every notebook PEP 8 compliant.

added 2 commits

• be83a778 - Trim trailing whitespace
• d83d1cbe - Don't install package & dependencies for pre-commit

Compare with previous version

This also now speeds up the checks stage of the CI from 2.5 - 3 minutes to about 30 seconds, mostly by not installing the package and all its dependencies.

cc @roscar

added 24 commits

• d83d1cbe...776ec254 - 23 commits from branch master
• 646631e7 - Merge branch 'master' into 'pre-commit-pass'

Compare with previous version

LGTM! I'd like to keep in the flake8 check since it should run only on changes, not on the whole file, meaning that its warnings are relevant. But it's not too critical so I'll accept it being removed without argument if you disagree

added 1 commit

• 5c4a370b - Restore flake8 check with ... diff

Compare with previous version

I've restored the flake8 check and tried to fix how it works with diffs. It looks like it still picks up lines near the ones changed in the MR, which is a bit annoying, but maybe we can live with that.

resolved all discussions

merged

mentioned in commit 50f3cde5