Fix MetadataClient.get_proposal_runs call arguments

Description

Call to MetadataClient.get_proposal_runs was not using the correct arguments, would always fail.

How Has This Been Tested?

It was not! I'm not even too sure when this gets called, @ahmedk mentioned when it should be used, maybe you could help out with testing?

Relevant Documents (optional)

N/A

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.

Reviewers

@calibration

added Waiting for review label

Looks like the method used to be call via the class object Oo LGTM I guess?

LGTM

changed milestone to %3.4.1

assigned to @roscar

It's called by get_dir_creation_date(), which is used in various notebooks. But any error coming from it is caught and it falls back to getting creationDate from the files, or a file mtime. So we wouldn't notice any problems.

yes, indeed. That what was happening before this fix. I guess that this function was changed in mdc without being back compatible and hence the bug of this MR.

I think it was in fact me that broke it, as part of a refactor. I anticipated that people might call MetadataClient.get_proposal_runs(mdc, ...), but not mdc.get_proposal_runs(mdc, ...).

Sweet, let's see what happens with this fix merged then!

merged

mentioned in commit 50be018c

removed Waiting for review label