Skip to content

[AGIPD] [Dark] Use function to get list of karabo_da from run for making Slurm jobs

Thomas Kluyver requested to merge find-agipd-das into master

Description

At present, if you run an AGIPD dark characterisation from the command line with the default options, it creates 16 Slurm jobs, 1 per module, regardless of how many modules are present. For AGIPD-500k, this means half the jobs fail, because they refer to nonexistant modules. However, when launching via the webservice, an explicit list of karabo_da is provided.

This looks in the run to get the list of data aggregators, in the same way that other notebooks get the sequence files.

To simplify things, I also removed the modules parameter, which is another way to specify the same thing as karabo_da. This does mean more typing if you want to specify a subset of modules at the command line (you can't use the 0-3 syntax, because karabo_da aren't numbers), but it avoids the complication of having potentially conflicting inputs.

How Has This Been Tested?

Run at the command line:

xfel-calibrate AGIPD dark \
    --in-folder /gpfs/exfel/d/raw/CALLAB/202031/p900113 \
    --out-folder /gpfs/exfel/data/scratch/kluyvert/agipd-dark-after \
    --run-high 9985 --run-med 9984 --run-low 9983

Report: AGIPDCharacterizeDarkImages.pdf

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@ahmedk

Merge request reports