Skip to content

Fix max gain plot in LPD correct notebook

Philipp Schmidt requested to merge fix/lpd_metro_positionFileList into master

Description

The reason for the failed LPD jobs is a StopIteration exception always thrown in the last plot of LPD corrections, where the maximum gain values are supposed to be seen. While the middlelayer code metro.positionFileList is not very robust in general, the actual reason is yet another no longer (for a long time) existing path in HDF files. Unfortunately there is no easy fix, as gain values are no longer present directly, but encoded in the upper bits of pixel data.

Given the instrument or detector experts did not complain about this for at least a year, I will assume the plot to not be relevant and disable the whole section.

UPDATE: It is possible to fix this plot rather than removing it, as the data is present in corrected files.

How Has This Been Tested?

Seeing the color of those lines change to the one for comments.

UPDATE: Tested using corrected files successfully with p2743, r218:

xfel-calibrate lpd CORRECT --slurm-scheduling 80 --slurm-mem 750 --request-time 2021-08-15T23:16:38 --slurm-name correct_FXE_lpd_202102_p002743_r218 --report-to ./report --cal-db-timeout 300000 --cal-db-interface tcp://max-exfl016:8015#8044 --karabo-da LPD03 --mem-cells 512 --max-cells-db 512 --overwrite --sequences-per-node 1 --in-folder /gpfs/exfel/exp/FXE/202102/p002743/raw --out-folder ./out --karabo-id FXE_DET_LPD1M-1 --run 218 --priority 1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Reviewers

@danilevc @ahmedk

FYI @jsztuk @yousefh

Edited by Philipp Schmidt

Merge request reports