Skip to content

Fix/select max pulses

Karim Ahmed requested to merge fix/select_max_pulses into master

This is a fix for reported issue at: https://in.xfel.eu/redmine/issues/106968

Description

for run /gpfs/exfel/exp/SPB/202102/p002510/raw/r0023/, the 12th sequence has only one train of 202 memory cells and 202 pulseIds. As the max_pulses is set by default to [0, 352, 1], correcting this sequence fail due to trying to access an index out of bounds.

Validate_selected_cells was modified to only validate the range of max_cells at the class AGIPDCorrection's initialization. and to modify max_cells if maximum selected pulse range is greater than the operating memory cells.

How Has This Been Tested?

Relevant Documents (optional)

max_pulses_352_.pdf max_pulses = [0, 352, 1], mem_cells 202 max_pulses_50.pdf max_pulses = [0, 50, 2], mem_cells 202

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring code with no functionality changes)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.

Reviewers

@danilevc @jsztuk @kluyvert

Edited by Karim Ahmed

Merge request reports