Fix/select max pulses

This is a fix for reported issue at: https://in.xfel.eu/redmine/issues/106968

Description

for run /gpfs/exfel/exp/SPB/202102/p002510/raw/r0023/, the 12th sequence has only one train of 202 memory cells and 202 pulseIds. As the max_pulses is set by default to [0, 352, 1], correcting this sequence fail due to trying to access an index out of bounds.

Validate_selected_cells was modified to only validate the range of max_cells at the class AGIPDCorrection's initialization. and to modify max_cells if maximum selected pulse range is greater than the operating memory cells.

How Has This Been Tested?

Relevant Documents (optional)

max_pulses_352_.pdf max_pulses = [0, 352, 1], mem_cells 202 max_pulses_50.pdf max_pulses = [0, 50, 2], mem_cells 202

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Refactor (refactoring code with no functionality changes)

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

Reviewers

@danilevc @jsztuk @kluyvert

changed the description

hi Karim, thanks a lot to fixing it. Just a short question (just to be sure):

• max_pulses flag is used for selecting pulses for processing.

Did you tested that this functionality is still working when you select (e.g. range(0,64,2)? Thanks!

OT: anyway, I think max_pulses is a confusing name.. probably it would be more clear if it is rather called something like sel_cells or proc_cells..

Thanks, I think it's LGTM.
I like how you've added an extra print to clarify that the input was modified to fit the available pulses.

added 1 commit

• 5609b5f4 - MR suggestions

Compare with previous version

resolved all threads

Thanks for the review!

added 1 commit

• 28a16411 - keep using pulse range instead of pulse_list

Compare with previous version

added 1 commit

• f1e633b4 - use bitwise logical and

Compare with previous version

added 1 commit

• 05c53c24 - modify validate_selected_pulses

Compare with previous version

resolved all threads

resolved all threads

added 1 commit

• 34b32843 - Apply suggestion to src/cal_tools/agipdlib.py

Compare with previous version

enabled an automatic merge when the pipeline for 34b32843 succeeds

merged

mentioned in commit 3c06a7c0

changed milestone to %3.4.2