Skip to content
Snippets Groups Projects

[pnCCD] [CORRECT][DARK] EXtra-data and pasha

Merged Karim Ahmed requested to merge feat/Extra_data_pnCCD into master
  1. Add Extra data for reading raw data for CORRECT and DARK notebooks.
  2. Using pasha in parallelizing data processing instead of pyDetLib.
  3. Removing all pyDetlib function, instead for common-mode and plotting.
  4. Use balance_sequences for pnccd correction.
  • Performance wise. The PnCCD gained a lot from these changes. The correct notebook was not doing any parallelization over images or sequence files.

It went from 3 hours for correcting 12 sequences at /gpfs/exfel/exp/SQS/202031/p900166/raw/r0347 to about 7 mins, after using parallelization over sequence files and pasha over images.

Description

How Has This Been Tested?

Correct

Production case comparison (unfair one)

MASTER run correction

Extra-data run correction

Fair comparison of correcting one sequence only.

MASTER one sequences correction

Extra-data one sequences correction

DARK [x5 speed up]

Master dark

Extra-data dark

NOTE: data quality wise. Noise generated constants are the same after specifying relative tolerance parameter to 1e-4

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactor (refactoring code with no functionality changes)

Checklist:

Reviewers

@schmidtp @kluyvert

Edited by Karim Ahmed

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Karim Ahmed added 119 commits

    added 119 commits

    Compare with previous version

  • Karim Ahmed marked this merge request as ready

    marked this merge request as ready

  • Karim Ahmed changed title from WIP: EXtra-data for [pnCCD] [CORRECT] and [DARK] to [pnCCD] [CORRECT][DARK] EXtra-data and pasha

    changed title from WIP: EXtra-data for [pnCCD] [CORRECT] and [DARK] to [pnCCD] [CORRECT][DARK] EXtra-data and pasha

  • Karim Ahmed changed the description

    changed the description

  • assigned to @ahmedk

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 1 commit

    added 1 commit

    Compare with previous version

  • Karim Ahmed added 2 commits

    added 2 commits

    • b93555e9 - revert cal_tools.tools changes
    • 4b9648bd - use extra-data to find available files to correct

    Compare with previous version

  • Karim Ahmed resolved all threads

    resolved all threads

  • Karim Ahmed added 1 commit

    added 1 commit

    • 453bf1ac - separate correction processes

    Compare with previous version

  • Philipp Schmidt changed milestone to %3.5.0

    changed milestone to %3.5.0

  • Karim Ahmed added 1 commit

    added 1 commit

    • da91659b - separate correction processes

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading