Skip to content
Snippets Groups Projects

Add explicit dependencies on matplotlib, scipy

Merged Thomas Kluyver requested to merge fix/reqs into master

Description

I noticed that although various notebooks use matplotlib & scipy, we weren't actually declaring them as dependencies. I've taken the versions already installed on max-exfl016 (in /home/xcal/calibration_webservice_venv), so it shouldn't change anything immediately. But if we recreate the environment, we'll get the same specific versions again rather than whatever other dependencies pull in.

There are more packages installed on max-exfl016 which aren't in setup.py - these were only the ones that I noticed were used directly from this project.

How Has This Been Tested?

We already run with these versions in production.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.

Reviewers

@roscar @ahmedk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading