Fix launching work directly (not via Slurm)
All threads resolved!
All threads resolved!
Description
The --no-cluster-job
option was failing to even start jobs. Closes #58.
How Has This Been Tested?
Launched on max-exfl-display:
xfel-calibrate AGIPD CORRECT \
--in-folder /gpfs/exfel/exp/SPB/202131/p900230/raw --run 174 \
--out-folder /gpfs/exfel/data/scratch/kluyvert/agipd-calib-900230-174-direct \
--karabo-id SPB_DET_AGIPD1M-1 --karabo-id-control SPB_IRU_AGIPD1M1 --karabo-da-control AGIPD1MCTRL00 \
--modules 0 --sequences 0 --no-cluster-job
I let this run until it saved the first HDF5 output files, and then cancelled it (Ctrl-C) so as not to hog the login node. Before these changes, it was failing to even start running the notebooks.
Types of changes
- Bug fix (non-breaking change which fixes an issue)
Checklist:
- My code follows the code style of this project.
Reviewers
Edited by Thomas Kluyver
Merge request reports
Activity
Filter activity
added 1 commit
- 12752fb3 - check_output() takes an input kwarg, check_call() doesn't
I've now tested this (on a Maxwell login node) all the way to generating the report and moving it to the output directory: AGIPDOfflineCorrection.pdf . There were a few more changes needed to make finalize happy without Slurm.
@roscar is experimenting with it on the online cluster.
- Resolved by Karim Ahmed
- Resolved by Karim Ahmed
mentioned in commit 2cd82d53
changed milestone to %3.4.3
Please register or sign in to reply