Skip to content

[Jungfrau][DARK][CORRECT] Feat/fixed gain jungfrau

Karim Ahmed requested to merge feat/Fixed_gain_jungfrau into master

Adding gain mode condition to differentiate between fixed and dynamic run operation. using jungfrau settings in slow data.

Description

This MR is related to: https://git.xfel.eu/detectors/cal_db_interactive/-/merge_requests/76

Operating conditions

  1. Adding new operating condition for Jungfrau: gain_mode
  • A condition similar to AGIPD's gain_mode. 0 for adaptive gain and 1 for fixed gain.

Darks

  1. New enums for the run setting. based on medium and low runs decide the gain mode (fixgain1 and fixgain2).
  2. New badpixel enum + refactoring the available enums (WRONG_GAIN_VALUE).
  3. The new bad pixel is identified by marking the pixels with wrong gain values. (e.g. g==1 in a high gain run)

Correct

  1. Avoid correcting pixels with memory cell of 255. (A value indicating wrong cell image due to reciever and detector issues.)

Fixed gain_mode if medium and low runs are

The generated constants are only used for correcting runs with settings of fixgain1 or fixgain2.

How Has This Been Tested?

  • Tested With runs from HED proposal p900227:
    • [Single]: 62, 63, 64
    • [Burst]: 65, 66, 67

Test results for detectors JNGFR01 and JNGFR02 for runs:

  • [Single]: 96, 97, 98
  • [Burst]: 100, 101, 102

are available at:

/gpfs/exfel/data/scratch/ahmedk/test/latest_jf_fixed_gain

  • As there was an identified issue with the gains for module jungfrau_M039. A new runs are expected to do final tests. The tests results from the module _M039 was found good.

Relevant Documents (optional)

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add gain mode to injected and retrieved constants.
  • Use high thresholds for fixed gain.
  • Update badpixels with wrong pixels in wrong gain.
  • Avoid correcting images with cell value 255.
  • Test with new runs and a different module other than _M039

Reviewers

@mramilli @danilevc @schmidtp @hammerd

Edited by Karim Ahmed

Merge request reports