[Jungfrau][DARK][CORRECT] Feat/fixed gain jungfrau
-
Review changes -
-
Download -
Patches
-
Plain diff
Adding gain mode condition to differentiate between fixed and dynamic run operation. using jungfrau settings in slow data.
Description
This MR is related to: https://git.xfel.eu/detectors/cal_db_interactive/-/merge_requests/76
Operating conditions
- Adding new operating condition for Jungfrau:
gain_mode
- A condition similar to AGIPD's gain_mode. 0 for adaptive gain and 1 for fixed gain.
Darks
- New enums for the run setting. based on medium and low runs decide the gain mode (
fixgain1
andfixgain2
). - New badpixel enum + refactoring the available enums (
WRONG_GAIN_VALUE
). - The new bad pixel is identified by marking the pixels with wrong gain values. (e.g. g==1 in a high gain run)
Correct
- Avoid correcting pixels with memory cell of 255. (A value indicating wrong cell image due to reciever and detector issues.)
Fixed gain_mode if medium and low runs are
The generated constants are only used for correcting runs with settings of fixgain1
or fixgain2
.
How Has This Been Tested?
- Tested With runs from HED proposal p900227:
- [Single]: 62, 63, 64
- [Burst]: 65, 66, 67
Test results for detectors JNGFR01
and JNGFR02
for runs:
- [Single]: 96, 97, 98
- [Burst]: 100, 101, 102
are available at:
/gpfs/exfel/data/scratch/ahmedk/test/latest_jf_fixed_gain
- As there was an identified issue with the gains for module jungfrau_M039. A new runs are expected to do final tests. The tests results from the module _M039 was found good.
Relevant Documents (optional)
Types of changes
- New feature (non-breaking change which adds functionality)
- Bug fix (non-breaking change which fixes an issue)
Checklist:
-
Add gain mode to injected and retrieved constants. -
Use high thresholds for fixed gain. -
Update badpixels with wrong pixels in wrong gain. -
Avoid correcting images with cell value 255. -
Test with new runs and a different module other than _M039
Reviewers
Edited by Karim Ahmed
Merge request reports
Compare and
Show latest version
- version 26a8215588
- version 25a8215588
- version 2473b62500
- version 235dc543b3
- version 22570c27f8
- version 218ab2d0ec
- version 20c8e49fca
- version 19b65c14b2
- version 1870d640b4
- version 17653dfaf7
- version 162f024f9b
- version 158807b525
- version 14ce9f6834
- version 1301898440
- version 1289f3c872
- version 11a0fb8dcb
- version 10a0fb8dcb
- version 9603c3a8a
- version 8d9c3709d
- version 7d4bd2bcf
- version 65eb9ee8c
- version 57d6db7f5
- version 4a7f90cef
- version 349fcd1b1
- version 29339c2ee
- version 19339c2ee
- master (base)
- latest versionba76c14421 commits,
- version 26a821558820 commits,
- version 25a821558820 commits,
- version 2473b6250019 commits,
- version 235dc543b318 commits,
- version 22570c27f817 commits,
- version 218ab2d0ec16 commits,
- version 20c8e49fca15 commits,
- version 19b65c14b214 commits,
- version 1870d640b413 commits,
- version 17653dfaf712 commits,
- version 162f024f9b11 commits,
- version 158807b52510 commits,
- version 14ce9f68349 commits,
- version 13018984409 commits,
- version 1289f3c8728 commits,
- version 11a0fb8dcb6 commits,
- version 10a0fb8dcb6 commits,
- version 9603c3a8a5 commits,
- version 8d9c3709d5 commits,
- version 7d4bd2bcf4 commits,
- version 65eb9ee8c3 commits,
- version 57d6db7f52 commits,
- version 4a7f90cef2 commits,
- version 349fcd1b12 commits,
- version 29339c2ee1 commit,
- version 19339c2ee38 commits,
Compare changes
- Side-by-side
- Inline
There are no changes yet
No changes between version 6 and version 6
Loading